-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win 465 index observability 1 #4538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6ab3c1b in 22 seconds
More details
- Looked at
151
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/src/lib/utils.ts:20
- Draft comment:
Ensure that the additional condition!j.canceled
inisJobCancelable
is intended and does not cause any unintended behavior. This condition was not present in the original function definitions in the other files. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_G5kh0a09uVKOdkV5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Deploying windmill with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on d609140 in 22 seconds
More details
- Looked at
7
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. backend/ee-repo-ref.txt:1
- Draft comment:
The change here is a simple update of a reference hash, which is typical for updating a dependency or a submodule reference. No issues found. - Reason this comment was not posted:
Confidence changes required:0%
The change in the file is a simple update of a reference hash, which is typical for updating a dependency or a submodule reference. This doesn't require any changes or comments as it is a standard practice.
Workflow ID: wflow_GcCyFcIlP6z7yXTG
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
https://github.com/windmill-labs/windmill-ee-private/pull/75
Important
Centralized
isJobCancelable
function inutils.ts
and enhancedGlobalSearchModal.svelte
to display index metadata and lock ownership status.isJobCancelable
function inutils.ts
and removed duplicate definitions fromRunRow.svelte
,RunsTable.svelte
, and+page.svelte
.GlobalSearchModal.svelte
now displaysindexMetadata
andlost_lock_ownership
status in the job preview section.RunRow.svelte
,RunsTable.svelte
, and+page.svelte
to use centralizedisJobCancelable
function.This description was created by for d609140. It will automatically update as commits are pushed.